AI Assistant: adjust command descriptions#33636
Merged
anna-shakhova merged 6 commits intoMay 20, 2026
Merged
Conversation
8aca5e0 to
edefc48
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the AI Grid Assistant’s command guidance and user-facing messages, and adjusts a few command behaviors to better match the intended “human-friendly” indexing and configuration semantics.
Changes:
- Switch
selectByIndexesto accept 1-based row indexes (normalize to 0-based internally) and update related tests/messages. - Update paging command messaging to display 1-based page numbers to the user.
- Tighten
summarycommand args contract (require bothtotalItemsandgroupItems) and strengthen system prompt guidance around optional args emission.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/selection.ts | Adjusts selectByIndexes to treat input as 1-based and normalizes before calling the grid API; expands clearSelection description. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/paging.ts | Updates pageIndex description and default message to show 1-based page numbers. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/focus.ts | Tweaks focusRowByKey description text. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/columns.ts | Updates command descriptions and changes Zod import style. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/selection.test.ts | Updates tests to match 1-based selectByIndexes input. |
| packages/devextreme/js/__internal/grids/grid_core/ai_assistant/commands/tests/paging.test.ts | Updates tests for the new 1-based page number messaging. |
| packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/summary.ts | Makes totalItems/groupItems required, updates summary/clearSummary descriptions, and changes clear behavior to write empty arrays. |
| packages/devextreme/js/__internal/grids/data_grid/ai_assistant/commands/tests/summary.test.ts | Updates schema and execution tests to require both arrays and validate new clear behavior. |
| packages/devextreme/js/__internal/core/ai_integration/templates/index.ts | Strengthens system prompt rules for omitting unused optional fields in generated actions. |
edefc48 to
268c5a6
Compare
268c5a6 to
c06db67
Compare
c06db67 to
3603a9d
Compare
Raushen
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.